On Sat, Feb 10, 2024 at 06:15:45PM +0100, Martin Wilck wrote:
> Gentle review reminder.
>
> On Wed, 2024-01-31 at 12:48 +0100, Martin Wilck wrote:
> > The Infinibox hwtable entry had fast_io_fail and dev_loss both set to
> > 15,
> > which has the effect that fast_io_fail is switched off (dev_loss
> > timeout
> > must be higher than fast_io_fail timeout).
> >
> > Remove the dev_loss value, which will cause the default of 600 to be
> > used.
> > Experience shows that dev_loss_tmo values below a few minutes are
> > seldom
> > helpful.
> >
> > Fixes: 55da608 ("libmultipath: update INFINIDAT builtin config")
> > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> > Cc: Arnon Yaari <arnony@xxxxxxxxxxxxx>
Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> > Cc: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
> > Cc: Tom Abraham <tabraham@xxxxxxxx>
> > Cc: Jiri Belka <jiri.belka@xxxxxxxx>
> > ---
> > libmultipath/hwtable.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> > index 808af54..9ef3e45 100644
> > --- a/libmultipath/hwtable.c
> > +++ b/libmultipath/hwtable.c
> > @@ -1161,7 +1161,6 @@ static struct hwentry default_hw[] = {
> > .minio_rq = 1,
> > .flush_on_last_del = FLUSH_ENABLED,
> > .fast_io_fail = 15,
> > - .dev_loss = 15,
> > },
> > /*
> > * Kaminario
