On 2024-02-13 01:25, Lukas Wunner wrote:
On Mon, Feb 12, 2024 at 11:30:58AM -0500, Mathieu Desnoyers wrote:In preparation for checking whether the architecture has data cache aliasing within alloc_dax(), modify the error handling of virtio virtio_fs_setup_dax() to treat alloc_dax() -EOPNOTSUPP failure as non-fatal. Co-developed-by: Dan Williams <dan.j.williams@xxxxxxxxx> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches")That's a v4.0 commit, yet this patch uses DEFINE_FREE() which is only available in v6.6 but not any earlier stable kernels.
I asked this question to Greg KH before creating this patch, and his answer was to implement my fix for master, and stable kernels would take care of backporting all the required dependencies. Now if I look at latest 6.1, 5.15, 5.10, 5.4, 4.19 stable kernels, none seem to have include/linux/cleanup.h today. But I suspect that sooner or later relevant master branch fixes will require stable kernels to backport cleanup.h, so why not do it now ? Thanks, Mathieu
So the Fixes tag feels a bit weird. Apart from that, Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>
-- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com
