Re: [PATCH] multipath-tools: fix an assignment ambiguity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-01-22 at 23:42 +0100, Xose Vazquez Perez wrote:
> spotted by indent:
> ./kpartx/gpt.c:623: Warning:old style assignment ambiguity in "=-".
> Assuming "= -"
> 
> Cc: Martin Wilck <mwilck@xxxxxxxx>
> Cc: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> Cc: Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx>
> Cc: DM-DEVEL ML <dm-devel@xxxxxxxxxxxxxxx>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
> ---
>  kpartx/gpt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This "ambiguity" must relate to some ancient compilers accepting '=-'
as an alias for '-='. That must predate K&R 1st edition (1978), which
clearly defines the assignment operator syntax for operator 'op' as
'op=' [1].

But well, it's always good to eliminate warnings, so

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>

[1] https://www.academia.edu/34487452/First_edition_of_c_by_dennis_ritche







[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux