Re: [PATCH] multipathd: the local path change is not considered

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2024-01-18 at 09:30 +0100, Martin Wilck wrote:
> > 
> > >  	struct config *conf;
> > >  
> > >  	oldpriority = pp->priority;
> > > @@ -2138,8 +2138,11 @@ int update_prio(struct path *pp, int
> > > refresh_all)
> > >  		pthread_cleanup_pop(1);
> > >  	}
> > >  
> > > -	if (pp->priority == oldpriority && !refresh_all)
> > > -		return 0;
> > > +	if (pp->priority != oldpriority)
> > > +		local_changed = 1;
> > > +	else
> > > +		if (!refresh_all)
> > > +			return 0;
> 
> Just realized that this would unnecessarily run through the loop
> below
> if (pp->priority != oldpriority && !refresh_all).

Sorry, this was nonsense. The commit msg of 6ccd7b8 explains that we
must run the loop if "changed" is true, even if refresh_all is not set.

Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux