On Tue, 2024-01-16 at 02:05 -0500, Benjamin Marzinski wrote:
> The code acted like AUTO_RESIZE_UNDEFINED didn't exist, but since
> conf->auto_resize was never set to AUTO_RESIZE_NEVER, the default was
> in
> fact AUTO_RESIZE_UNDEFINED, which ended up getting treated like
> AUTO_RESIZE_GROW_SHRINK. Remove AUTO_RESIZE_UNDEFINED, so
> AUTO_RESIZE_NEVER really is the default.
>
> Fixes: 981b83ad1 ("multipathd: Add auto_resize config option")
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
The analysis is correct, but the fix differs from what we did for other
options. We won't be able to cleanly change the default later on with
this patch applied.
I would prefer to keep AUTO_RESIZE_UNDEF and DEFAULT_AUTO_RESIZE and
just change the condition in uev_update_path() from "auto_resize !=
AUTO_RESIZE_NEVER" to "(auto_resize == AUTO_RESIZE_GROW_ONLY ||
auto_resize == AUTO_RESIZE_GROW_SHRINK)", unless you have strong
reasons not to do so.
Regards,
Martin
