On Thu, Jan 11 2024 at 11:24P -0500, Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: > > > Bw, can someone help with what dm_integrity_profile is for? > > It is basically identical to the no-op one, just with a different > > name. With the no-op removal it is the only one outside of the pi > > once, and killing it would really help with some de-virtualization > > I've looked at a while ago. > > No particular objections from me wrt. using a flag. > > However, I believe the no-op profile and associated plumbing was a > requirement for DM. I forget the details. Mike? I'll have to take a closer look.. staking device always complicates things. But the dummy functions that got wired up with this commit are suspect: 54d4e6ab91eb block: centralize PI remapping logic to the block layer Effectively the entirety of the dm_integrity_profile is "we don't do anything special".. so yes it would be nice to not require indirect calls to accomplish what dm-integrity needs from block core. Mike