On Fri, 2023-12-15 at 21:53 -0500, Benjamin Marzinski wrote: > On Thu, Dec 14, 2023 at 05:15:39PM +0100, Martin Wilck wrote: > > On Tue, 2023-12-05 at 18:57 -0500, Benjamin Marzinski wrote: > > > The commands to show a multipath device are supposed to return > > > its > > > current state without updating it. Even when reset is 0, > > > update_multipath() still can update the device. Call, > > > __setup_multipath() instead to just fetch the current state. > > > > > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > > > > __setup_multipath() can still call remove_map_and_stop_waiter(), do > > we > > want to avoid that, too, maybe? > > If there really is no multipath device anymore, I don't see a benefit > in > keeping it around in multipathd until the next path check, do you? No, but that wasn't my point. I thought the rationale was that a "show" command shouldn't change the internal state of multipathd in any way. That would imply not calling remove_map_and_stop_waiter(). But I agree it's really a corner case. I just wanted to make sure that this was no oversight. Martin
