Re: [PATCH 10/16] libmultipath: print error when find_mp_by_str() fails.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2023-12-12 at 18:53 -0500, Benjamin Marzinski wrote:
> None of the callers of find_mp_by_str() print any message if they
> fail
> because the map name is invalid. Print one in find_mp_by_str() to
> save
> the effort of adding it to all the callers.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

This will be printed to the journal; clients won't see the message
unless they check the journal, too. It's ok to add the message, but I
don't think it' a condlog(0), which is normally reserved to fatal
multipathd errors. I'd make it a 2; after all, it's most likely just a
typo by the user.

Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux