Re: [PATCH 2/4] multipathd: remove reset option from update_multipath

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2023-12-14 at 15:08 +0100, Martin Wilck wrote:
> On Tue, 2023-12-05 at 16:23 -0500, Benjamin Marzinski wrote:
> > Since all callers now set the reset argument, it's unnecessary to
> > keep
> > it as an argument.
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> 
> This breaks the dmevents test, because __wrap_update_multipath()
> hasn't
> been updated. I'll fix it.

Actually, this caused the dmevents test to hang, because the failure 
in __wrap_update_multipath() would cause an immediate return to the
cmocka code, bypassing cleanup_lock() in dmevent_loop(), causing
deadlock when the lock is taken in the next invocation.

See e.g.
https://github.com/openSUSE/multipath-tools/actions/runs/7116036356/job/19373506650#step:17:49

Martin







[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux