Re: [PATCH 2/2] Makefile.inc: always use /usr/include for includedir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2023-11-10 at 14:53 -0500, Benjamin Marzinski wrote:
> The current build system, with nothing overridden, will install the
> header files to /include, which AFAIK isn't correct for any
> distribution.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

I have the same comment as for patch 1/2 - correct for the default
case, but the more obvious fix would be changing the default of
usr_prefix (our current default prefix="" usr_prefix="" is arguably
bad).

Also, I bet that there are cases out there where the assumption that 
paths for multipath and kernel headers are equal would fail.

I'm going to submit my suggestion here; I'm of course open to further
discussion.

Thanks
Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux