Re: [device-mapper-dm:dm-vdo-wip 55/90] drivers/md/dm-vdo/block-map.h:35:37: warning: 'UNMAPPED_BLOCK_MAP_ENTRY' defined but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 02, 2023 at 11:11:54AM -0400, Mike Snitzer wrote:
> [lkp: please update your scripts to use the new
> dm-devel@xxxxxxxxxxxxxxx when emailing dm-devel. The MAINTAINERS file
> was updated so I don't know why you'd still be using the old
> dm-devel@xxxxxxxxxx address]

Hi Mike, thanks a lot for this information. We've updated the
configuration of the bot to use the new mailing list address.

Best Regards,
Yujie

> On Thu, Nov 02 2023 at  1:43P -0400,
> kernel test robot <lkp@xxxxxxxxx> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git dm-vdo-wip
> > head:   d4e7d305aaa9738d9606f986ad8f2f01edbb14b3
> > commit: 5a6d19abe1dc27648b64418df24ea0acef0f38d6 [55/90] dm vdo: enable configuration and building of dm-vdo
> > config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231102/202311021353.WMMPQspU-lkp@xxxxxxxxx/config)
> > compiler: alpha-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311021353.WMMPQspU-lkp@xxxxxxxxx/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202311021353.WMMPQspU-lkp@xxxxxxxxx/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    In file included from drivers/md/dm-vdo-target.c:16:
> > >> drivers/md/dm-vdo/block-map.h:35:37: warning: 'UNMAPPED_BLOCK_MAP_ENTRY' defined but not used [-Wunused-const-variable=]
> >       35 | static const struct block_map_entry UNMAPPED_BLOCK_MAP_ENTRY = {
> >          |                                     ^~~~~~~~~~~~~~~~~~~~~~~~
> > >> drivers/md/dm-vdo/block-map.h:34:38: warning: 'NO_PAGE' defined but not used [-Wunused-const-variable=]
> >       34 | static const physical_block_number_t NO_PAGE = 0xFFFFFFFFFFFFFFFF;
> >          |                                      ^~~~~~~
> > 
> > 
> > vim +/UNMAPPED_BLOCK_MAP_ENTRY +35 drivers/md/dm-vdo/block-map.h
> > 
> > fd98f3e3ccc645 Matthew Sakai 2023-10-26  33  
> > 15deeca3859a19 Matthew Sakai 2023-10-26 @34  static const physical_block_number_t NO_PAGE = 0xFFFFFFFFFFFFFFFF;
> > 15deeca3859a19 Matthew Sakai 2023-10-26 @35  static const struct block_map_entry UNMAPPED_BLOCK_MAP_ENTRY = {
> > 15deeca3859a19 Matthew Sakai 2023-10-26  36  	.mapping_state = VDO_MAPPING_STATE_UNMAPPED & 0x0F,
> > 15deeca3859a19 Matthew Sakai 2023-10-26  37  	.pbn_high_nibble = 0,
> > 15deeca3859a19 Matthew Sakai 2023-10-26  38  	.pbn_low_word = __cpu_to_le32(VDO_ZERO_BLOCK & UINT_MAX),
> > 15deeca3859a19 Matthew Sakai 2023-10-26  39  };
> > 15deeca3859a19 Matthew Sakai 2023-10-26  40  
> > 
> > :::::: The code at line 35 was first introduced by commit
> > :::::: 15deeca3859a19abfaadd333fb3df7a45087ab3e dm vdo: implement the block map page cache
> > 
> > :::::: TO: Matthew Sakai <msakai@xxxxxxxxxx>
> > :::::: CC: Mike Snitzer <snitzer@xxxxxxxxxx>
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> > 
> 
> UNMAPPED_BLOCK_MAP_ENTRY isn't defined until commit 15deeca3859a1 but
> it is used by the earlier commit fd98f3e3ccc645.  So it needs moving
> to that earlier commit.
> 
> But that aside, the above warning is correctly complaining about the
> definition of static variables that aren't ever used.  We need to
> define in block-map.c but declare them as extern in block-map.h
> 
> I've fixed this up in linux-dm.git's dm-vdo (and rebased dm-vdo-wip)
> 




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux