Re: [PATCH 5/6] multipath-tools: systemd: require modprobe@dm_multipath.service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2023-10-25 at 19:43 -0400, Benjamin Marzinski wrote:
> On Tue, Oct 24, 2023 at 06:49:36PM +0200, mwilck@xxxxxxxx wrote:
> > From: Martin Wilck <mwilck@xxxxxxxx>
> > 
> > Since 92f0893 ("multipath-tools: install modules-
> > load.d/multipath.conf"), we
> > use modules-load.d to load the dm-multipath module early on. That
> > isn't
> > optimal, because the module will always be loaded, even if
> > multipathd is
> > not running.
> > 
> > Use systemd's "modprobe@.service" instead to make sure the module
> > is loaded
> > before multipathd starts. If "multipath -u" is invoked from udev
> > rules
> > before multipathd.service has been started, it will access the
> > socket,
> > which will autostart multipathd via socket activation and cause the
> > dm-multipath module to be loaded.
> > 
> > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

I just realized that modprobe@.service has only be available since
systemd v245 (2020). I should make this change conditional on the
systemd version.

Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux