Thanks, this looks good to me and fixes the problems I've seen Reviewed-by: Christoph Hellwig <hch@xxxxxx> Tested-by: Christoph Hellwig <hch@xxxxxx> FTI, this is the xfstests change we need to use dm-error for zoned devices in xfstests: diff --git a/common/rc b/common/rc index 741579af..9e07d79d 100644 --- a/common/rc +++ b/common/rc @@ -2174,12 +2174,10 @@ _require_dm_target() _notrun "This test requires dm $target support" fi - # dm-error cannot handle the zone information - # # dm-snapshot and dm-thin-pool cannot ensure sequential writes on # the backing device case $target in - error|snapshot|thin-pool) + snapshot|thin-pool) _require_non_zoned_device ${SCRATCH_DEV} ;; esac