Re: [PATCH] Fix hwtable test after "libmultipath: don't bother to recheck timeout"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 01, 2023 at 11:24:39PM +0200, mwilck@xxxxxxxx wrote:
> From: Martin Wilck <mwilck@xxxxxxxx>
> 
> The previous patch  "libmultipath: don't bother to recheck timeout"
> causes sysfs_get_timeout() to be called less frequently. Adapt the
> tests.
> 
Oops.

Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
>  tests/test-lib.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tests/test-lib.c b/tests/test-lib.c
> index 0bc49d5..f75ea31 100644
> --- a/tests/test-lib.c
> +++ b/tests/test-lib.c
> @@ -342,12 +342,6 @@ void mock_pathinfo(int mask, const struct mocked_path *mp)
>  			    mp->wwid);
>  	}
>  
> -	if (mask & DI_CHECKER) {
> -		/* get_state -> sysfs_get_timeout  */
> -		will_return(__wrap_udev_device_get_subsystem, "scsi");
> -		will_return(__wrap_udev_device_get_sysattr_value, "180");
> -	}
> -
>  	if (mask & DI_PRIO && mp->flags & NEED_SELECT_PRIO) {
>  
>  		/* sysfs_get_timeout, again (!?) */
> -- 
> 2.41.0
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux