Re: [PATCH -next v2 2/6] md: refactor action_store() for 'idle' and 'frozen'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

在 2023/06/13 16:02, Xiao Ni 写道:

在 2023/5/29 下午9:20, Yu Kuai 写道:
From: Yu Kuai <yukuai3@xxxxxxxxxx>

Prepare to handle 'idle' and 'frozen' differently to fix a deadlock, there
are no functional changes except that MD_RECOVERY_RUNNING is checked
again after 'reconfig_mutex' is held.


Can you explain more about why it needs to check MD_RECOVERY_RUNNING again here?

As I explain in the following comment:
+    /*
+     * Check again in case MD_RECOVERY_RUNNING is cleared before lock is
+     * held.
+     */
+    if (!test_bit(MD_RECOVERY_RUNNING, &mddev->recovery)) {
+        mddev_unlock(mddev);
+        return;
+    }

Thanks,
Kuai

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux