Re: [PATCH 10/31] block: remove the unused mode argument to ->release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 10/31] block: remove the unused mode argument to ->release
From: Christian Brauner <brauner@xxxxxxxxxx>
Date: Wed, 7 Jun 2023 10:34:57 +0200
Cc: Vignesh Raghavendra <vigneshr@xxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Chris Mason <clm@xxxxxx>, dm-devel@xxxxxxxxxx, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, linux-nilfs@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, linux-pm@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, Josef Bacik <josef@xxxxxxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20230606073950.225178-11-hch@lst.de>
References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-11-hch@lst.de>

On Tue, Jun 06, 2023 at 09:39:29AM +0200, Christoph Hellwig wrote:
> The mode argument to the ->release block_device_operation is never used,
> so remove it.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---

Good cleanup. Looks good to me,
Acked-by: Christian Brauner <brauner@xxxxxxxxxx>

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

References:
- decouple block open flags from fmode_t
  - From: Christoph Hellwig
- [PATCH 10/31] block: remove the unused mode argument to ->release
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release
Next by Date: Re: [PATCH 30/31] block: store the holder in file->private_data
Previous by thread: Re: [PATCH 10/31] block: remove the unused mode argument to ->release
Next by thread: Re: [PATCH 10/31] block: remove the unused mode argument to ->release
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]