Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 07 Jun 2023 21:17:42 -0400
Cc: Vignesh Raghavendra <vigneshr@xxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Chris Mason <clm@xxxxxx>, dm-devel@xxxxxxxxxx, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, linux-nilfs@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, linux-pm@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, Josef Bacik <josef@xxxxxxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20230606073950.225178-21-hch@lst.de> (Christoph Hellwig's message of "Tue, 6 Jun 2023 09:39:39 +0200")
Organization: Oracle
References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-21-hch@lst.de>

Christoph,

> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

References:
- decouple block open flags from fmode_t
  - From: Christoph Hellwig
- [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v12 5/9] nvme: add copy offload support
Next by Date: Re: [PATCH v7 0/5] Introduce provisioning primitives
Previous by thread: Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
Next by thread: Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]