When need_switch_pathgroup() is called by deferred_failback_tick(), there is a chance that mpp->paths will be NULL, even if there are paths in the multipath device's pathgroups. Instead check if there are multiple pathgroups, since multipath can't be using the wrong pathgroup if there is one or none. Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> --- multipathd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipathd/main.c b/multipathd/main.c index 584be895..6463d2b7 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -439,7 +439,7 @@ need_switch_pathgroup (struct multipath * mpp, bool *need_reload) if (!mpp) return 0; - if (!mpp->pg || VECTOR_SIZE(mpp->paths) == 0) + if (VECTOR_SIZE(mpp->pg) < 2) return 0; bestpg = select_path_group(mpp); -- 2.17.2 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
