Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 7 Jun 2023 14:21:31 +0200
Cc: Vignesh Raghavendra <vigneshr@xxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Chris Mason <clm@xxxxxx>, dm-devel@xxxxxxxxxx, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-nilfs@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, linux-pm@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, Josef Bacik <josef@xxxxxxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <30183892-dce6-6946-2f7a-1bc693a657a2@suse.de>
References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-9-hch@lst.de> <30183892-dce6-6946-2f7a-1bc693a657a2@suse.de>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Jun 07, 2023 at 02:19:00PM +0200, Hannes Reinecke wrote:
>> -	return true;
>> +	return __disk_check_media_change(disk,
>> +			disk_clear_events(disk, DISK_EVENT_MEDIA_CHANGE |
>> +						DISK_EVENT_EJECT_REQUEST));
>
> Can you move the call to disk_clear_events() out of the call to 
> __disk_check_media_change()?
> I find this pattern hard to read.

I suspect you've not done enough functional programming in your youth :)

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change
  - From: Hannes Reinecke

References:
- decouple block open flags from fmode_t
  - From: Christoph Hellwig
- [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change
  - From: Christoph Hellwig
- Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change
  - From: Hannes Reinecke

Prev by Date: Re: [PATCH 09/31] block: pass a gendisk to ->open
Next by Date: Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data
Previous by thread: Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change
Next by thread: Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]