Re: [PATCH 4/5] multipath-tools tests: add tests for group_by_tpg policy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2023-06-01 at 12:51 -0500, Benjamin Marzinski wrote:
> On Wed, May 31, 2023 at 03:30:02PM +0000, Martin Wilck wrote:
> > On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> > 
> > I wonder if it might make sense for group_by_tpg to mock calls to
> > getprio (assigning the prio from the path's TPG ID) rather than
> > calling
> > set_priority() directly.
> 
> It seems like it should be. I just continued with what the existing
> tests were
> already doing. Can improving these tests happen outside of this
> patchset?
> 

Yes.

Martin

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux