Re: [PATCH v6 20/20] block: mark bio_add_folio as __must_check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v6 20/20] block: mark bio_add_folio as __must_check
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 31 May 2023 06:29:45 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, Damien Le Moal <damien.lemoal@xxxxxxx>, cluster-devel@xxxxxxxxxx, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Andreas Gruenbacher <agruenba@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, gouhao@xxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, Mikulas Patocka <mpatocka@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Bob Peterson <rpeterso@xxxxxxxxxx>
In-reply-to: <3d45098a7640897cbace54713efe10d88b74c160.1685461490.git.johannes.thumshirn@wdc.com>
References: <cover.1685461490.git.johannes.thumshirn@wdc.com> <3d45098a7640897cbace54713efe10d88b74c160.1685461490.git.johannes.thumshirn@wdc.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, May 30, 2023 at 08:49:23AM -0700, Johannes Thumshirn wrote:
> +bool __must_check bio_add_folio(struct bio *, struct folio *, size_t len, size_t off);

Please spell out the parameters and avoid the overly long line.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

References:
- [PATCH v6 00/20] bio: check return values of bio_add_page
  - From: Johannes Thumshirn
- [PATCH v6 20/20] block: mark bio_add_folio as __must_check
  - From: Johannes Thumshirn

Prev by Date: Re: [PATCH v6 19/20] fs: iomap: use __bio_add_folio where possible
Next by Date: Re: [PATCH v6 08/20] jfs: logmgr: use __bio_add_page to add single page to bio
Previous by thread: Re: [PATCH v6 20/20] block: mark bio_add_folio as __must_check
Next by thread: [PATCH v6 19/20] fs: iomap: use __bio_add_folio where possible
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]