[PATCH] libmultipathd Avoid parsing errors due to unsupported designators

[Brian Bunker <brian@xxxxxxxxxxxxxxx>]

Unsupported designators, even if they are correct, will result
in parsing errors. Add support for these two:

Logical Unit Group (0x6)
Vendor Specific (0x0)

Mar 20 13:37:35 init107-18 multipath[45016]: parse_vpd_pg83:
invalid device designator at offset 87: 01060004
Mar 20 13:37:35 init107-18 multipath[45016]: parse_vpd_pg83:
invalid device designator at offset 131: 02000005

Thanks,
Brian

Signed-off-by: Brian Bunker <brian@xxxxxxxxxxxxxxx>
—
---
 libmultipath/discovery.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index d9ee2cb9..306884f6 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -1211,6 +1211,14 @@ parse_vpd_pg83(const unsigned char *in, size_t in_len,
                        invalid = (d[3] < 8);
                        new_prio = 2;
                        break;
+               case 0x6:
+                       /* Logical Unit Group */
+                       invalid = (d[3] != 4);
+                       break;
+               case 0x0:
+                       /* Vendor Specific */
+                       invalid = 0;
+                       break;
                case 0xa:
                        condlog(2, "%s: UUID identifiers not yet supported",
                                __func__);
--


--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel