Re: [PATCH v2 0/4] multipath: fix multipathd renaming issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 02, 2023 at 08:44:53AM +0000, Martin Wilck wrote:
> On Wed, 2023-02-01 at 09:56 -0600, Benjamin Marzinski wrote:
> > If a multipath device needs to be renamed and reloaded when
> > multipathd
> > starts, it will only get reloaded. This can happen if the multipath
> > configuration is different between the initramfs and regular
> > filesystem.
> > The only thing that can happen along with a rename is a force reload.
> > 
> > This patchset makes libmultipath also do all the other actions that
> > are
> > compatible with a rename.
> > 
> > changes in v2 (as suggested by Martin Wilck)
> > 0004: If the rename is impossible, multipath now checks for other
> >       actions, instead of always returning ACT_IMPOSSIBLE
> > 
> > Benjamin Marzinski (4):
> >   libmultipath: use select_reload_action in select_action
> >   libmultipath: select resize action even if reload is forced
> >   libmultipath: cleanup ACT_CREATE code in select_action
> >   libmultipath: keep renames from stopping other multipath actions
> > 
> >  libmultipath/configure.c | 107 +++++++++++++++++--------------------
> > --
> >  libmultipath/configure.h |   4 +-
> >  2 files changed, 49 insertions(+), 62 deletions(-)
> > 
> 
> 
> For the series:
> 
> Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>

It looks like you pulled the first version of my patches, without the
fix you suggested for impossible renames, into your queue branch. 

-Ben
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux