On Wed, 2023-02-01 at 08:39 -0600, Benjamin Marzinski wrote: > On Wed, Feb 01, 2023 at 08:00:25AM +0000, Martin Wilck wrote: > > > > > This code makes we wonder if we should transform the ACT_... enum > > into > > a bitmap of required actions that would be ORed together. > > At least ACT_RENAME is now orthogonal to the rest of the actions. > > I thought about that too, as well as breaking rename out from the > other > actions, so it could be checked separately. But since, AFAICS, there > are only these three special cases, it didn't seem like there'd be > much > benefit, and it could give the false impression that something like > ACT_RELOAD | ACT_SWITCHPG makes sense. If you feel strongly about > this, > I can do it, but I did consider it and I didn't see a reason to > change > it. Ok, leave it as you had it. Fine with me. Martin -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
