> @@ -330,7 +344,9 @@ static void brd_submit_bio(struct bio *b
> struct bio_vec bvec;
> struct bvec_iter iter;
>
> - if (bio_op(bio) == REQ_OP_DISCARD) {
> + if (bio_op(bio) == REQ_OP_DISCARD ||
> + bio_op(bio) == REQ_OP_SECURE_ERASE ||
> + bio_op(bio) == REQ_OP_WRITE_ZEROES) {
> brd_do_discard(brd, bio);
> goto endio;
> }
> @@ -464,6 +480,8 @@ static int brd_alloc(int i)
> if (discard) {
> disk->queue->limits.discard_granularity = PAGE_SIZE;
> blk_queue_max_discard_sectors(disk->queue, UINT_MAX);
> + blk_queue_max_write_zeroes_sectors(disk->queue, UINT_MAX);
> + blk_queue_max_secure_erase_sectors(disk->queue, UINT_MAX);
> }
>
The previous patch has the following description for the discard module
param:
MODULE_PARM_DESC(discard, "Support discard");
But you are reusing it here to enable write zeroes and sec erase.
MODULE_PARM_DESC's "desc" parameter also needs to be updated in this patch.
I understand that all these operations kind of do the same thing at the
end, so it is upto you to decide if you want to add individual module param
for each operation or club them together as you have done here. If you
do the latter, then changing the module param variable `discard` to
something more generic would give more clarity as well.
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel
