On 8/9/22 2:26 PM, Bart Van Assche wrote:
> On 8/8/22 17:04, Mike Christie wrote:
>> +static int sd_pr_in_command(struct block_device *bdev, u8 sa,
>> + unsigned char *data, int data_len)
>> +{
>> + struct scsi_disk *sdkp = scsi_disk(bdev->bd_disk);
>> + struct scsi_device *sdev = sdkp->device;
>> + struct scsi_sense_hdr sshdr;
>> + u8 cmd[10] = { 0, };
>> + int result;
>
> Isn't "{ }" instead of "{ 0, }" the preferred way to zero-initialize a data structure?
The original code used { 0, } and that seems common sd.c. { } was not used in sd.c.
I didn't see anything in coding-style.rst. It does not make any difference to me
other than it's better to be consistent unless we are supposed to be transitioning
to a new style.
>
>> +
>> + cmd[0] = PERSISTENT_RESERVE_IN;
>> + cmd[1] = sa;
>
> Can the above two assignments be moved into the initializer of cmd[]?
>
Yes, but it was like the first comment. The original code didn't do
that and it seemed more common to not do it. Do we want to switch
or are we transitioning? It does not matter to me. Both are simple changes.
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel
