Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
From: "Jason A. Donenfeld" <Jason@xxxxxxxxx>
Date: Wed, 4 May 2022 11:44:37 +0200
Cc: Andy Shevchenko <andy@xxxxxxxxxx>, Mike Snitzer <msnitzer@xxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Mimi Zohar <zohar@xxxxxxxxxxxxx>, Milan Broz <gmazyland@xxxxxxxxx>, device-mapper development <dm-devel@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Linux Crypto Mailing List <linux-crypto@xxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <YnJI4Ru0AlUgrr9C@zx2c4.com>
References: <alpine.LRH.2.02.2204241648270.17244@file01.intranet.prod.int.rdu2.redhat.com> <CAHk-=wh+Z+OKH3jRttWGHbWSQq2wVMtdnA=ntDiadZu=VxAC7w@mail.gmail.com> <alpine.LRH.2.02.2204250723120.26714@file01.intranet.prod.int.rdu2.redhat.com> <YnI7hE4cIfjsdKSF@antec> <YnJI4Ru0AlUgrr9C@zx2c4.com>

On Wed, May 04, 2022 at 11:42:27AM +0200, Jason A. Donenfeld wrote:
> (which might be semantically better anyway) and then
> let the function itself do the sign change (see below).
 
Actually, probably worse, not better. Didn't realize cu was being used
after the masking.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

References:
- [PATCH] hex2bin: make the function hex_to_bin constant-time
  - From: Mikulas Patocka
- Re: [PATCH] hex2bin: make the function hex_to_bin constant-time
  - From: Linus Torvalds
- [PATCH v2] hex2bin: make the function hex_to_bin constant-time
  - From: Mikulas Patocka
- Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
  - From: Stafford Horne
- Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
  - From: Jason A. Donenfeld

Prev by Date: Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
Next by Date: Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
Previous by thread: Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
Next by thread: [PATCH] dm-crypt: make printing of the key constant-time
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]