Re: [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size

Subject: Re: [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Tue, 3 May 2022 09:50:37 -0700
Cc: jiangbo.365@xxxxxxxxxxxxx, kch@xxxxxxxxxx, matias.bjorling@xxxxxxx, gost.dev@xxxxxxxxxxx, chao@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, clm@xxxxxx, dm-devel@xxxxxxxxxx, agk@xxxxxxxxxx, jonathan.derrick@xxxxxxxxx, kbusch@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, josef@xxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20220427160255.300418-6-p.raghav@samsung.com>
References: <20220427160255.300418-1-p.raghav@samsung.com> <CGME20220427160301eucas1p147d0dced70946e20dd2dd046b94b8224@eucas1p1.samsung.com> <20220427160255.300418-6-p.raghav@samsung.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 4/27/22 09:02, Pankaj Raghav wrote:

-	sector &= ~(ns->zsze - 1);
+	sector = rounddown(sector, ns->zsze);

The above change breaks 32-bit builds since ns->zsze is 64 bits wide andsince rounddown() uses the C division operator instead of div64_u64().


Thanks,

Bart.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size
  - From: Pankaj Raghav

References:
- [PATCH 00/16] support non power of 2 zoned devices
  - From: Pankaj Raghav
- [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size
  - From: Pankaj Raghav