On Mon, May 02, 2022 at 11:01:40AM -0500, Benjamin Marzinski wrote:
> On Mon, May 02, 2022 at 10:31:36AM +0000, Martin Wilck wrote:
> > On Fri, 2022-04-29 at 17:09 -0500, Benjamin Marzinski wrote:
> > > Make the config better align to MSA 4th, 5th and 6th Generation
> > > systems.
> > >
> > > Suggested-by: Jon Paul <Jon.Paul@xxxxxxx>
> > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> > > ---
> > > libmultipath/hwtable.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> > > index 0e1c0a41..0f0795c3 100644
> > > --- a/libmultipath/hwtable.c
> > > +++ b/libmultipath/hwtable.c
> > > @@ -182,8 +182,8 @@ static struct hwentry default_hw[] = {
> > > },
> > > {
> > > /* MSA 1040, 1050, 1060, 2040, 2050 and 2060 families
> > > */
> > > - .vendor = "HP",
> > > - .product = "MSA [12]0[456]0 SA[NS]",
> > > + .vendor = "(HP|HPE)",
> >
> > This changes nothing unless you use "^(HP|HPE)$", as our regex matching
> > is by substring.
>
> Fair enough. I'm just passing along the config I got. I'm not sure if
> they what it to be more immediately obvious to people looking at the
> configs that this applies to their device (which could have a vendor
> string of "HPE"). I'll leave it to HP to decide what, if anything, they
> want to change here.
I've talked to HP, and they would like to keep (HP|HPE), since they feel
that it's more obvious to readers. They are fine with whatever anchors
we feel should be added to the regular expression. I personally don't
think it matters much. Most of our vendor strings are unanchored and
since the product string must also match, it seems unlikely to cause
issues.
Do you have a strong feeling on this? Otherwise, I'm fine with the
config as they gave it to me.
-Ben
>
> -Ben
>
> > Regards,
> > Martin
> >
> >
> > > + .product = "MSA [12]0[456]0
> > > (SAN|SAS|FC|iSCSI)",
> > > .pgpolicy = GROUP_BY_PRIO,
> > > .pgfailback = -FAILBACK_IMMEDIATE,
> > > .no_path_retry = 18,
> >
> --
> dm-devel mailing list
> dm-devel@xxxxxxxxxx
> https://listman.redat.com/mailman/listinfo/dm-devel
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel
