On Tue, Apr 26, 2022 at 5:29 PM Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: > On Tue, 26 Apr 2022, Andy Shevchenko wrote: > > On Tue, Apr 26, 2022 at 08:07:44AM -0400, Mikulas Patocka wrote: > > > On Tue, 26 Apr 2022, Andy Shevchenko wrote: > > > > On Sun, Apr 24, 2022 at 10:48 PM Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: ... > > Still shadows error codes. > > > > > + return -EINVAL; > > > > > return -EINVAL; > > What do you mean? What's wrong with "return -EINVAL"? The actual error code is returned by hex_to_bin(). What is the point of shadowing it with the explicit value? -- With Best Regards, Andy Shevchenko -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
