> + if (bb->count && > + badblocks_check(bb, sector, num, &first_bad, &num_bad)) { Weird alignment here, continuing lines for conditionals are aligned either after the opening brace: if (bb->count && badblocks_check(bb, sector, num, &first_bad, &num_bad)) { or with double tabs. I tend to prefer the version I posted above. The being said, shouldn't this change even be in this patch and not just added once we add actual recovery support? -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel