On Apr 15, 2022 / 08:57, Damien Le Moal wrote: > On 4/15/22 01:47, Mike Snitzer wrote: > > On Thu, Apr 14 2022 at 12:29P -0400, > > Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > > > >> Thanks for the report, I've staged a fix here (btw, your change above > >> needs to be paired with the 2nd hunk of my fix otherwise you won't get > >> the bio split you desire): > >> > >> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.18&id=3dfb6f5e95f26215ca08d348ca2ddb5ea6ea2349 Thank you Mike. Yes, I confirmed that the 2nd hunk is required for split. > >> > >> I'll be sending this to Linus later today or tomorrow. > > > > FYI, I revised that commit with further cleanup to not pass > > 'unsigned *len' to alloc_multiple_bios(), this commit is what will be > > sent upstream soon: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.18&id=c2228f993c7592783b0a2bf7d169b17dfa4cbe2a > > Looks good to me. > > Nit: there is a typo in the commit message: > > dm_accept_paertial_bio() -> dm_accept_partial_bio() > > Feel free to add: > > Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> Another nit in the commit message is "abormal". I think you meant "abnormal". I tested this revised patch and confrimed it fixes the issue. Good. Thanks. Tested-by: Shinichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> -- Best Regards, Shin'ichiro Kawasaki -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
