On Fri, Mar 18, 2022 at 5:33 PM <mwilck@xxxxxxxx> wrote: > > From: Martin Wilck <mwilck@xxxxxxxx> > > running_state is only accessed while holding the config_lock, the > volatile qualifier is superfluous. > > Suggested-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx> Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > --- > multipathd/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/multipathd/main.c b/multipathd/main.c > index 1454a18..f3b8eb4 100644 > --- a/multipathd/main.c > +++ b/multipathd/main.c > @@ -127,7 +127,7 @@ static int poll_dmevents = 0; > static int poll_dmevents = 1; > #endif > /* Don't access this variable without holding config_lock */ > -static volatile enum daemon_status running_state = DAEMON_INIT; > +static enum daemon_status running_state = DAEMON_INIT; > /* Don't access this variable without holding config_lock */ > static bool __delayed_reconfig; > pid_t daemon_pid; > -- > 2.35.1 > -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
