While the original code is valid, it is not the obvious choice for the sizeof() call and in preparation to limit the scope of the list iterator variable the sizeof should be changed to the size of the array elements that are beings sorted. Signed-off-by: Jakob Koschel <jakobkoschel@xxxxxxxxx> --- drivers/md/dm-thin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index ec119d2422d5..2e41e50d6903 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -2251,7 +2251,7 @@ static unsigned sort_cells(struct pool *pool, struct list_head *cells) list_del(&cell->user_list); } - sort(pool->cell_sort_array, count, sizeof(cell), cmp_cells, NULL); + sort(pool->cell_sort_array, count, sizeof(*pool->cell_sort_array), cmp_cells, NULL); return count; } base-commit: 34e047aa16c0123bbae8e2f6df33e5ecc1f56601 -- 2.25.1 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
