On Thu, Feb 17, 2022 at 08:55:29PM +0100, mwilck@xxxxxxxx wrote:
> From: Martin Wilck <mwilck@xxxxxxxx>
>
> Hi Christophe,
>
> since 3ab1f3b ("libmultipath: print message if setting dev_loss_tmo is unsupported"),
> multipathd prints a warning at level 2 for every map for which dev_loss_tmo can't
> be set. This results in a large number of warnings if there are many maps with such
> unsupported protocols, like this:
>
> multipathd[1398]: 36001405328d6683b6cb4739943adf643: setting dev_loss_tmo is unsupported for protocol scsi:unspec
>
> This patch set makes changes the code to print this warning only once per unsupported
> protocol. It would have been simpler to never print the warning more than once, but
> I figured that might suppress important information in some cases.
>
> Regards
> Martin
Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
>
> Martin Wilck (4):
> libmultipath: enable linear ordering of bus/proto tuple
> libmultipath: use bus_protocol_id() in snprint_path_protocol()
> libmultipath: enable defining a static bitfield
> libmultipath: only warn once about unsupported dev_loss_tmo
>
> libmultipath/discovery.c | 4 ++-
> libmultipath/print.c | 58 +++++++++++++++-------------------------
> libmultipath/structs.c | 10 +++++++
> libmultipath/structs.h | 13 +++++++--
> libmultipath/util.h | 10 +++++++
> 5 files changed, 55 insertions(+), 40 deletions(-)
>
> --
> 2.35.1
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel
