Re: [PATCH] libmultipath: fix printing native nvme multipath topology.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2022-02-16 at 00:12 -0600, Benjamin Marzinski wrote:
> Since commit 2f05df4 ("libmultipath: use strbuf in print.c"), when
> multipath prints the topology of native nvme devices, instead of
> printing the multipath device information, it prints "w [G]:d s".
> This
> is because nvme_style() switched from calling snprintf(), which
> supports
> format specifiers, to append_strbuf_str(), which doesn't, while still
> keeping the same string, "%%w [%%G]:%%d %%s". Remove the extra
> percent
> signs, since they don't need to be escaped in append_strbuf_str().
> 
> Fixes: 2f05df4 ("libmultipath: use strbuf in print.c")
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

Oops, thanks a lot for catching this!

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>


--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux