> static void alloc_multiple_bios(struct bio_list *blist, struct clone_info *ci,
> struct dm_target *ti, unsigned num_bios,
> unsigned *len)
> @@ -1224,14 +1218,14 @@ static void __send_duplicate_bios(struct clone_info *ci, struct dm_target *ti,
> case 1:
> clone = alloc_tio(ci, ti, 0, len, GFP_NOIO);
> if (len)
> - bio_setup_sector(clone, ci->sector, *len);
> + clone->bi_iter.bi_size = to_bytes(*len);
> __map_bio(clone);
> break;
> default:
> alloc_multiple_bios(&blist, ci, ti, num_bios, len);
> while ((clone = bio_list_pop(&blist))) {
> if (len)
> - bio_setup_sector(clone, ci->sector, *len);
> + clone->bi_iter.bi_size = to_bytes(*len);
> __map_bio(clone);
> }
> break;
> @@ -1350,7 +1344,6 @@ static int __split_and_process_bio(struct clone_info *ci)
> len = min_t(sector_t, max_io_len(ti, ci->sector), ci->sector_count);
>
> clone = alloc_tio(ci, ti, 0, &len, GFP_NOIO);
> - bio_advance(clone, to_bytes(ci->sector - clone->bi_iter.bi_sector));
> clone->bi_iter.bi_size = to_bytes(len);
Maybe move the clone->bi_iter.bi_size assignment into alloc_tio as well?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel
