On Wed, Feb 02, 2022 at 11:07:37PM +0000, Jane Chu wrote: > On 2/2/2022 1:20 PM, Jane Chu wrote: > >> Wouldn't it make more sense to move these helpers out of line rather > >> than exporting _set_memory_present? > > > > Do you mean to move > > return change_page_attr_set(&addr, numpages, __pgprot(_PAGE_PRESENT), 0); > > into clear_mce_nospec() for the x86 arch and get rid of _set_memory_present? > > If so, sure I'll do that. > > Looks like I can't do that. It's either exporting > _set_memory_present(), or exporting change_page_attr_set(). Perhaps the > former is more conventional? These helpers above means set_mce_nospec and clear_mce_nospec. If they are moved to normal functions instead of inlines, there is no need to export the internals at all. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
