On Wed, 2022-02-02 at 12:35 -0600, Benjamin Marzinski wrote: > > > + vector_foreach_slot_backwards(vecs->mpvec, mpp, i) { > > > > Any special reason why you walk the vector backwards? > > reload_and_sync_map() can remove a item from vecs->mpvec. Walking > backwards means we don't need to care. The other option would be to > walk forwards but add "i--" whenver reload_and_sync_map() removes the > map. Right, I forgot about that. @Muneendra, perhaps add a short comment for forgetful reviewers :-/ Martin -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel