Re: [PATCH 1/4] multipath-tools: avoid using GZIP Makefile variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2022-01-09 at 10:29 +0000, Sergei Trofimovich wrote:
> `gzip` supports (deprecated) `GZIP` environment variable. If it's
> already present Makefile would override it and pass it through
> causing
> thre breakage:
> 
>     $ dev>GZIP=-n make
>     gzip -9 -c mpath_persistent_reserve_in.3 >
> mpath_persistent_reserve_in.3.gz
>     gzip: -c: option not valid in GZIP environment variable
>     Try `gzip --help' for more information.
> 
> Fix build by renaming GZIP variable to GZIP_PROG to avoid collision.
> 
> CC: Martin Wilck <mwilck@xxxxxxxx>
> CC: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> Signed-off-by: Sergei Trofimovich <slyich@xxxxxxxxx>

For the series: Looks good, no breakage found, so

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>



--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux