On Mon, 2021-11-29 at 10:19 -0600, Benjamin Marzinski wrote: > On Fri, Nov 26, 2021 at 03:34:59PM +0100, Martin Wilck wrote: > > > > I'm going to fix that, but I assume you're aware that our code is > > far > > from being consistent in this respect. This holds also for other > > patches in this series. Do you want me to re-format all of them? > > Huh? I mean that the line doesn't start with a tab, but instead has 8 > spaces. A quick grep through the source code in your queue branch > only > turns that up in some of the files in the tests directory and in > files > we've just imported > > # grep -l "^ " `find ./ -name "*.[ch]"` > ./libmultipath/nvme/nvme-ioctl.c > ./tests/pgpolicy.c > ./tests/util.c > ./tests/directio.c > ./tests/mpathvalid.c > ./tests/dmevents.c > ./third-party/valgrind/drd.h > ./third-party/valgrind/valgrind.h Right. It must be some change in the way emacs handles indentation, then. I'm not aware that I'm doing anything different than before. Unfortunately, there are still some space-indented lines in my v3 submission. I'll prepare a v4, and try to figure out what changed in my environment. Sorry. Martin -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel