On Wed, 2021-11-24 at 14:41 -0600, Benjamin Marzinski wrote: > On Thu, Nov 18, 2021 at 11:57:55PM +0100, mwilck@xxxxxxxx wrote: > > From: Martin Wilck <mwilck@xxxxxxxx> > > > > Have struct mutex_lock take an optional wakeup function. > > unlock() is renamed to __unlock() in order to prevent it from > > being called by mistake. > > > > This changes offsets in "struct vectors", requiring a major > > libmultipath version bump. While the strucure is already changed, > > in order to avoid this in the future, move the lock to the end > > of "struct vectors". > > > > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx> > > In libmultipath.version, I would have said that set_wakeup_fn was > added > in 10.0.0, instead of 9.2.0, which is a version that never actually > existed, but I don't think that's going to cause any problems so, > > Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> We should consider whether we want bump the version numbers only when we submit to Christophe, or maybe once per major patch series that touches the ABI. This is something that I could Martin -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel