On Wed, Nov 17, 2021 at 08:50:55PM +0000, Martin Wilck wrote: > On Wed, 2021-11-17 at 14:33 -0600, Benjamin Marzinski wrote: > > > > Changes from v1 as suggested by Martin Wilck: > > > > 0001: update libmultipath.version to handle ABI change in struct > > config > > 0003: Clarify commit message > > Did you overlook the two other comments I had on 0003, or did you > deliberately ignore them? Just asking. Now that I look at this, I'd rather not change the reconfigure() and configure() argument names to reload_type. That's the name of the global variable which has serialization concerns, and reusing it as an argument seems like it would lead to more confusion. Actually, since reload_type can only be changed when switching to the DAEMON_CONFIGURE state, and you can't switch to that state again until after do the reconfigure, it's safe to simply have configure() access the global variable, reload_type. -Ben > > Martin -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
