Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it
From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Tue, 12 Oct 2021 23:12:52 -0700
Cc: Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Josef Bacik <josef@xxxxxxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, David Sterba <dsterba@xxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Phillip Lougher <phillip@xxxxxxxxxxxxxxx>, ntfs3@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20211013051042.1065752-5-hch@lst.de>
References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de>

On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I think it might make sense, as you suggest earlier, to add a "bytes"
helper. This is the first user in the series needing:

	bdev_nr_sectors(...bdev) << SECTOR_SHIFT

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

-- 
Kees Cook

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it
  - From: Song Liu

References:
- don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 01/29] bcache: remove bdev_sectors
Next by Date: Re: [PATCH 12/29] cramfs: use bdev_nr_sectors instead of open coding it
Previous by thread: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it
Next by thread: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]