On Sun, Sep 12, 2021 at 06:31:32PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > blk-crypto-fallback.c has many static variables with inconsistent names, > e.g. "blk_crypto_*", "crypto_*", and some unprefixed names. This is > confusing. Consolidate them all into a struct named > "blk_crypto_fallback" so that it's clear what they are. I always find this pattern of a single instance global struct rather confusing. What is the advantage over just using a consistent prefix? -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
