On Tue, Sep 07, 2021 at 08:56:33AM +0200, mwilck@xxxxxxxx wrote: > From: Martin Wilck <mwilck@xxxxxxxx> Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> for the set. > > Hello Christophe, hello Ben, > > here are a few final small fixes for the next multipath-tools PR: > https://github.com/opensvc/multipath-tools/pull/13 > > (Christophe, please give Ben a few days for review before merging). > > Notes: > > - The patch for libmultipath.version differs from the one I posted > previously (https://listman.redhat.com/archives/dm-devel/2021-September/msg00011.html). > In the previous one I hadn't sticked to the guide line I had > set up myself (bumping the version of every symbol in the ABI > for incompatible changes). The previous patch (bumping only the > version of the symbols that had actually changed) has some advantages, > in particular being able to track which symbols actually differ between > versions. We may want to discuss changing the policy towards > this procedure in the future, but we can't do it silently like I did > in the first version of this patch. > - I wrote previously that "libmultipath: drop unnecessary parameter > from remove_map()" broke the directio test, but that was a braino. > It broke the dmevents tests. The fix is in this series. > > Regards, > Martin > > Martin Wilck (3): > libmultipath.version: adapt to changes in remove_map > multipath-tools tests: fix dmevents test > Update .gitignore > > .gitignore | 4 ++++ > libmultipath/libmultipath.version | 17 +++++++---------- > tests/dmevents.c | 4 +--- > 3 files changed, 12 insertions(+), 13 deletions(-) > > -- > 2.33.0 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel
