The sparse tool complains as follows: drivers/md/persistent-data/dm-btree.c:696:5: warning: symbol 'shadow_child' was not declared. Should it be static? This symbol is not used outside of dm-btree.c, so marks it static. Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx> --- drivers/md/persistent-data/dm-btree.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c index b8d21b6..a29bcb8 100644 --- a/drivers/md/persistent-data/dm-btree.c +++ b/drivers/md/persistent-data/dm-btree.c @@ -693,8 +693,10 @@ static int split_one_into_two(struct shadow_spine *s, unsigned parent_index, * child of the given parent node. Making sure to update the parent to point * to the new shadow. */ -int shadow_child(struct dm_btree_info *info, struct dm_btree_value_type *vt, - struct btree_node *parent, unsigned index, struct dm_block **result) +static int shadow_child(struct dm_btree_info *info, + struct dm_btree_value_type *vt, + struct btree_node *parent, + unsigned index, struct dm_block **result) { int r, inc; dm_block_t root; -- 2.6.2 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel