From: Martin Wilck <mwilck@xxxxxxxx>
In virtual deployments, SCSI passthrough over dm-multipath devices is a
common setup. The qemu "pr-helper" was specifically invented for it. I
believe that this is the most important real-world scenario for sending
SG_IO ioctls to device-mapper devices.
In this configuration, guests send SCSI IO to the hypervisor in the form of
SG_IO ioctls issued by qemu. But on the device-mapper level, these SCSI
ioctls aren't treated like regular IO. Until commit 2361ae595352 ("dm mpath:
switch paths in dm_blk_ioctl() code path"), no path switching was done at
all. Worse though, if an SG_IO call fails because of a path error,
dm-multipath doesn't retry the IO on a another path; rather, the failure is
passed back to the guest, and paths are not marked as faulty. This is in
stark contrast with regular block IO of guests on dm-multipath devices, and
certainly comes as a surprise to users who switch to SCSI passthrough in
qemu. In general, users of dm-multipath devices would probably expect failover
to work at least in a basic way.
This patch fixes this by taking a special code path for SG_IO on request-
based device mapper targets. Rather then just choosing a single path,
sending the IO to it, and failing to the caller if the IO on the path
failed, it retries the same IO on another path for certain error codes,
using the same logic as blk_path_error() to determine if a retry would make
sense for the given error code. Moreover, it sends a message to the
multipath target to mark the path as failed.
I am aware that this looks sort of hack-ish. I'm submitting it here as an
RFC, asking for guidance how to reach a clean implementation that would be
acceptable in mainline. I believe that it fixes an important problem.
Actually, it fixes the qemu SCSI-passthrough use case on dm-multipath,
which is non-functional without it.
One problem remains open: if all paths in a multipath map are failed,
normal multipath IO may switch to queueing mode (depending on
configuration). This isn't possible for SG_IO, as SG_IO requests can't
easily be queued like regular block I/O. Thus in the "no path" case, the
guest will still see an error. If anybody can conceive of a solution for
that, I'd be interested.
Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
---
block/scsi_ioctl.c | 5 +-
drivers/md/dm.c | 134 ++++++++++++++++++++++++++++++++++++++++-
include/linux/blkdev.h | 2 +
3 files changed, 137 insertions(+), 4 deletions(-)
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index 6599bac0a78c..bcc60552f7b1 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -279,8 +279,8 @@ static int blk_complete_sghdr_rq(struct request *rq, struct sg_io_hdr *hdr,
return ret;
}
-static int sg_io(struct request_queue *q, struct gendisk *bd_disk,
- struct sg_io_hdr *hdr, fmode_t mode)
+int sg_io(struct request_queue *q, struct gendisk *bd_disk,
+ struct sg_io_hdr *hdr, fmode_t mode)
{
unsigned long start_time;
ssize_t ret = 0;
@@ -369,6 +369,7 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk,
blk_put_request(rq);
return ret;
}
+EXPORT_SYMBOL_GPL(sg_io);
/**
* sg_scsi_ioctl -- handle deprecated SCSI_IOCTL_SEND_COMMAND ioctl
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 50b693d776d6..443ac5e5406c 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -29,6 +29,8 @@
#include <linux/part_stat.h>
#include <linux/blk-crypto.h>
#include <linux/keyslot-manager.h>
+#include <scsi/sg.h>
+#include <scsi/scsi.h>
#define DM_MSG_PREFIX "core"
@@ -522,8 +524,9 @@ static int dm_blk_report_zones(struct gendisk *disk, sector_t sector,
#define dm_blk_report_zones NULL
#endif /* CONFIG_BLK_DEV_ZONED */
-static int dm_prepare_ioctl(struct mapped_device *md, int *srcu_idx,
- struct block_device **bdev)
+static int _dm_prepare_ioctl(struct mapped_device *md, int *srcu_idx,
+ struct block_device **bdev,
+ struct dm_target **target)
{
struct dm_target *tgt;
struct dm_table *map;
@@ -553,20 +556,147 @@ static int dm_prepare_ioctl(struct mapped_device *md, int *srcu_idx,
goto retry;
}
+ if (r >= 0 && target)
+ *target = tgt;
+
return r;
}
+static int dm_prepare_ioctl(struct mapped_device *md, int *srcu_idx,
+ struct block_device **bdev)
+{
+ return _dm_prepare_ioctl(md, srcu_idx, bdev, NULL);
+}
+
static void dm_unprepare_ioctl(struct mapped_device *md, int srcu_idx)
{
dm_put_live_table(md, srcu_idx);
}
+static int dm_sg_io_ioctl(struct block_device *bdev, fmode_t mode,
+ void __user *arg)
+{
+ struct mapped_device *md = bdev->bd_disk->private_data;
+ struct sg_io_hdr hdr;
+ int rc, srcu_idx;
+ char path_name[BDEVNAME_SIZE];
+
+ if (copy_from_user(&hdr, arg, sizeof(hdr)))
+ return -EFAULT;
+
+ if (hdr.interface_id != 'S')
+ return -EINVAL;
+
+ if (hdr.dxfer_len > (queue_max_hw_sectors(bdev->bd_disk->queue) << 9))
+ return -EIO;
+
+ for (;;) {
+ struct dm_target *tgt;
+ struct sg_io_hdr rhdr;
+
+ rc = _dm_prepare_ioctl(md, &srcu_idx, &bdev, &tgt);
+ if (rc < 0) {
+ DMERR("%s: failed to get path: %d\n",
+ __func__, rc);
+ goto out;
+ }
+
+ rhdr = hdr;
+
+ rc = sg_io(bdev->bd_disk->queue, bdev->bd_disk, &rhdr, mode);
+
+ DMDEBUG("SG_IO via %s: rc = %d D%02xH%02xM%02xS%02x\n",
+ bdevname(bdev, path_name), rc,
+ rhdr.driver_status, rhdr.host_status,
+ rhdr.msg_status, rhdr.status);
+
+ /*
+ * Errors resulting from invalid parameters shouldn't be retried
+ * on another path.
+ */
+ switch (rc) {
+ case -ENOIOCTLCMD:
+ case -ENOTTY:
+ case -EFAULT:
+ case -EINVAL:
+ case -EPERM:
+ goto out;
+ default:
+ break;
+ }
+
+ if (rhdr.info & SG_INFO_CHECK) {
+ /*
+ * See if this is a target or path error.
+ * Compare blk_path_error(), scsi_result_to_blk_status(),
+ * blk_errors[].
+ */
+ switch (rhdr.host_status) {
+ case DID_OK:
+ if (scsi_status_is_good(rhdr.status))
+ rc = 0;
+ break;
+ case DID_TARGET_FAILURE:
+ rc = -EREMOTEIO;
+ goto out;
+ case DID_NEXUS_FAILURE:
+ rc = -EBADE;
+ goto out;
+ case DID_ALLOC_FAILURE:
+ rc = -ENOSPC;
+ goto out;
+ case DID_MEDIUM_ERROR:
+ rc = -ENODATA;
+ goto out;
+ default:
+ /* Everything else is a path error */
+ rc = -EIO;
+ break;
+ }
+ }
+
+ if (rc == 0) {
+ /* success */
+ if (copy_to_user(arg, &rhdr, sizeof(rhdr)))
+ rc = -EFAULT;
+ goto out;
+ }
+
+ /* Failure - fail path by sending a message to the target */
+ if (!tgt->type->message) {
+ DMWARN("invalid target!");
+ rc = -EIO;
+ goto out;
+ } else {
+ char bdbuf[BDEVT_SIZE];
+ char *argv[2] = { "fail_path", bdbuf };
+
+ scnprintf(bdbuf, sizeof(bdbuf), "%u:%u",
+ MAJOR(bdev->bd_dev), MINOR(bdev->bd_dev));
+
+ DMDEBUG("sending \"%s %s\" to target\n", argv[0], argv[1]);
+ rc = tgt->type->message(tgt, 2, argv, NULL, 0);
+ if (rc < 0)
+ goto out;
+ }
+
+ dm_unprepare_ioctl(md, srcu_idx);
+ }
+out:
+ dm_unprepare_ioctl(md, srcu_idx);
+ return rc;
+}
+
static int dm_blk_ioctl(struct block_device *bdev, fmode_t mode,
unsigned int cmd, unsigned long arg)
{
struct mapped_device *md = bdev->bd_disk->private_data;
int r, srcu_idx;
+ if ((dm_get_md_type(md) == DM_TYPE_REQUEST_BASED) &&
+ cmd == SG_IO)
+ return dm_sg_io_ioctl(bdev, mode, (void __user *)arg);
+
r = dm_prepare_ioctl(md, &srcu_idx, &bdev);
if (r < 0)
goto out;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index c032cfe133c7..bded0e6546da 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -934,6 +934,8 @@ extern int scsi_cmd_ioctl(struct request_queue *, struct gendisk *, fmode_t,
unsigned int, void __user *);
extern int sg_scsi_ioctl(struct request_queue *, struct gendisk *, fmode_t,
struct scsi_ioctl_command __user *);
+extern int sg_io(struct request_queue *, struct gendisk *,
+ struct sg_io_hdr *, fmode_t);
extern int get_sg_io_hdr(struct sg_io_hdr *hdr, const void __user *argp);
extern int put_sg_io_hdr(const struct sg_io_hdr *hdr, void __user *argp);
--
2.31.1
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel
