Re: [PATCH v2 2/3] libmultipath: cleanup uid_attribute checking code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2021-02-24 at 00:33 -0600, Benjamin Marzinski wrote:
> In get_uid(), if pp->getuid is NULL, multipath will check the
> pp->uid_attribute to get the wwid.  If pp->uid_attribute is NULL,
> nothing will happen in that block of code, because both
> udev_available
> and has_uid_fallback() are false if pp->uid_attribute is NULL. So
> instead of multiple checks if pp->uid_attribute is NULL, just check
> once
> for the code block.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>


--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux