Re: [PATCH 5/6] multipathd: Fix multipathd stopping on shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 18, 2020 at 11:31:25PM +0000, Martin Wilck wrote:
> On Fri, 2020-12-18 at 17:06 -0600, Benjamin Marzinski wrote:
> > According to man "systemd.special"
> > 
> > "shutdown.target: ... Services that shall be terminated on system
> > shutdown shall add Conflicts= and Before= dependencies to this unit
> > for
> > their service unit, which is implicitly done when
> > DefaultDependencies=yes is set (the default)."
> > 
> > multipathd.service sets DefaultDependencies=no and includes the
> > Conflits= dependency, but not the Before= one. This can cause
> > multipathd
> > to continue running past when it is supposed to during shutdown.
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> 
> Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>

Martin, I noticed that this commit didn't make it into your queue
branch. I assume it's just an oversight. Right?

-Ben

> 
> -- 
> Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107
> SUSE  Software Solutions Germany GmbH
> HRB 36809, AG Nürnberg GF: Felix
> Imendörffer
> 

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux